Enforce integer bounds in type encoders#773
Merged
Merged
Conversation
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Snehil-Shah
commented
Jun 22, 2026
Comment on lines
+41
to
+48
| # Lexeme positions can range from 1 to 16383 with a silent ceiling at the top. | ||
| # Ref: https://www.postgresql.org/docs/current/datatype-textsearch.html#DATATYPE-TSVECTOR | ||
| if position < 1 do | ||
| raise DBConnection.EncodeError, | ||
| Postgrex.Utils.encode_msg(position, 1..@max_position) | ||
| end | ||
|
|
||
| position = min(position, @max_position) |
Contributor
Author
There was a problem hiding this comment.
According to postgres docs:
"Position values can range from 1 to 16383; larger numbers are silently set to 16383"
Decided to follow their behavior, although I do feel that explicitly raising for max position can be a more consistent experience. WDYT?
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started from
intervaland found quite a few types missing integer bound checks before stuffing the binary, silently wrapping the bits and corrupting data, without the user knowing.I have added bound checks to the following types, such that it now rejects out-of-bound values like PG actually would:
inetintervalmacaddrnumerictidtsvector